Conversation
Collaborator
Author
|
Since This also simplifies the entire setup a bit, with the potential drawback that the types files isn't linted for stylistic changes (but this should probably be handled by Standard anyways) |
LinusU
commented
Nov 28, 2023
Comment on lines
+47
to
+49
| "browser.js", | ||
| "index.d.ts", | ||
| "index.js", |
Collaborator
Author
There was a problem hiding this comment.
Potentially, this aren't needed, but the files documentation only mentions main, and I think it's better to just include them all...
Collaborator
Author
|
The tests are failing for unrelated reasons, but this fixes the "Lint" check so I think that we could merge this, and then I can rebase #2310 on top of this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!