Python binding: remove global ErrorCodes dependency from checkError success path#237
Draft
Python binding: remove global ErrorCodes dependency from checkError success path#237
ErrorCodes dependency from checkError success path#237Conversation
Co-authored-by: martinweismann <30837766+martinweismann@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix global usage in Base.__del__() to avoid errors
Python binding: remove global Feb 23, 2026
ErrorCodes dependency from checkError success path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib3mfusers reported noisy shutdown-time exceptions from generated Python bindings (Base.__del__→Release→checkError) when module globals were already torn down. The failure was caused by dereferencingErrorCodes.SUCCESSduring interpreter finalization.Change
Source/buildbindingpython.goto avoid enum/global lookup for the success case.checkErrornow compares directly against the numeric success code (0) instead ofErrorCodes.SUCCESS.value.Why this addresses the issue
None/unavailable.Generated code delta
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.