[PWGLF] Add new process function for mixing#15245
Open
skundu692 wants to merge 7 commits intoAliceO2Group:masterfrom
Open
[PWGLF] Add new process function for mixing#15245skundu692 wants to merge 7 commits intoAliceO2Group:masterfrom
skundu692 wants to merge 7 commits intoAliceO2Group:masterfrom
Conversation
skundu692
requested review from
alibuild,
ercolessi,
mpuccio,
omvazque and
romainschotter
as code owners
github-actions
bot
changed the title
vkucera
reviewed
Mar 3, 2026
| static inline float phi0To2Pi(float phi) | ||
| { | ||
| // harmonic=1, min=0 => [0, 2pi) | ||
| return RecoDecay::constrainAngle(phi, 0.0f, 1); |
| static inline float deltaPhiMinusPiToPi(float phiA, float phiB) | ||
| { | ||
| // returns in [-pi, pi) | ||
| const float d = phi0To2Pi(phiA) - phi0To2Pi(phiB); |
Collaborator
There was a problem hiding this comment.
The phi0To2Pi calls are useless.
| { | ||
| // returns in [-pi, pi) | ||
| const float d = phi0To2Pi(phiA) - phi0To2Pi(phiB); | ||
| return RecoDecay::constrainAngle(d, -TMath::Pi(), 1); |
Collaborator
There was a problem hiding this comment.
Take Pi from O2, not from ROOT.
| const float dPtSE = std::abs(static_cast<float>(l1SE.Pt() - l2SE.Pt())); | ||
| const float dEtaSE = std::abs(static_cast<float>(l1SE.Eta() - l2SE.Eta())); | ||
| const float dPhiSE = std::abs(RecoDecay::constrainAngle( | ||
| RecoDecay::constrainAngle(static_cast<float>(l1SE.Phi()), 0.f, 1) - |
Collaborator
There was a problem hiding this comment.
Providing default values is useless.
alibuild
approved these changes
Mar 3, 2026
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @skundu692.
Collaborator
|
Error while checking build/O2Physics/o2 for 4cfeb6a at 2026-03-04 02:43: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.