Add/use createDirectoriesIfAbsent method, robust against concurrent calls#8667
Merged
davidrohr merged 2 commits intoAliceO2Group:devfrom Apr 27, 2022
Merged
Add/use createDirectoriesIfAbsent method, robust against concurrent calls#8667davidrohr merged 2 commits intoAliceO2Group:devfrom
davidrohr merged 2 commits intoAliceO2Group:devfrom
Conversation
ironMann
reviewed
Apr 27, 2022
Common/Utils/src/FileSystemUtils.cxx
Outdated
Contributor
There was a problem hiding this comment.
Hi @shahor02, I would simplify this as:
std::filesystem::create_directories(path);
if (!std::filesystem::is_directory(path)) {
throw std::runtime_error(fmt::format("Failed to create {} directory", path));
}
Collaborator
Author
There was a problem hiding this comment.
Thanks, indeed, I see that it is not throwing on the existing directory! Changed to even shorter
if (!std::filesystem::create_directories(path) && !std::filesystem::is_directory(path)) {
throw std::runtime_error(fmt::format("Failed to create {} directory", path));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.