Skip to content

[QC-769] Desambiguify DS and Merger names #8660

Merged
ktf merged 4 commits intoAliceO2Group:devfrom
Barthelemy:desambiguify-merger-name
Apr 28, 2022
Merged

[QC-769] Desambiguify DS and Merger names #8660
ktf merged 4 commits intoAliceO2Group:devfrom
Barthelemy:desambiguify-merger-name

Conversation

@Barthelemy
Copy link
Collaborator

No description provided.

@Barthelemy Barthelemy requested a review from knopers8 as a code owner April 26, 2022 15:16
knopers8
knopers8 previously approved these changes Apr 27, 2022
@knopers8 knopers8 changed the title [QC-769] Desambiguify DS and dispatcher names [QC-769] Desambiguify DS and Merger names Apr 27, 2022
framework::DataProcessorSpec merger;

merger.name = mergerIdString() + "-" + mName + std::to_string(mLayer) + "l-" + std::to_string(mId);
merger.name = mergerIdString() + "-" + mConfig.detectorName + "-" + mName + std::to_string(mLayer) + "l-" + std::to_string(mId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could consider switching the order to comply with the order in QC

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Barthelemy
Copy link
Collaborator Author

@ktf I think that the fullCI error is spurrious. Could you confirm and merge ?

@ktf
Copy link
Member

ktf commented Apr 28, 2022

Yes, agreed.

@davidrohr @shahor02 since a couple of days I see:

## sw/BUILD/O2-full-system-test-latest/log
--
Detected critical problem in logfile digi.log
digi.log-[77046:FDDDigitizer]: [21:34:13][INFO] FDD: Sending ROMode= 3 to GRPUpdater
digi.log-[77050:CPVDigitizer]: [21:34:55][STATE] Exiting FairMQ state machine
digi.log:[77050:CPVDigitizer]: [21:34:55][FATAL] unknown error while setting up workflow in o2-sim-digitizer-workflow.
digi.log-[ERROR] pid 77050 crashed with 1
digi.log-[INFO] QUIT_REQUESTED
killing child 75041
killing child 75044
killing child 75047
killing child 75048
killing child 75052
killing child 75054
killing child 77027
killing child 98226
/sw/slc8_x86-64/O2/8660-slc8_x86-64-local1/share/scripts/jobutils.sh: line 49: 75041 Killed                  eval ${finalcommand} >> ${logfile} 2>&1
Running: TIME="#walltime %e" /sw/slc8_x86-64/O2/8660-slc8_x86-64-local1/share/scripts/monitor-mem.sh /usr/bin/time --output=digi.log_time './digi.log_tmp.sh'
/usr/bin/time --output=digi.log_time ./digi.log_tmp.sh
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
   Missing FileEntry for HepMC3/Data/GenParticleData.h
   requested to autoload type HepMC3::GenParticleData
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:

was there any relevant change in FDD?

@ktf ktf disabled auto-merge April 28, 2022 08:13
@ktf ktf merged commit 946387c into AliceO2Group:dev Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants