[QC-769] Desambiguify DS and Merger names #8660
Merged
ktf merged 4 commits intoAliceO2Group:devfrom Apr 28, 2022
Merged
Conversation
knopers8
previously approved these changes
Apr 27, 2022
knopers8
reviewed
Apr 27, 2022
| framework::DataProcessorSpec merger; | ||
|
|
||
| merger.name = mergerIdString() + "-" + mName + std::to_string(mLayer) + "l-" + std::to_string(mId); | ||
| merger.name = mergerIdString() + "-" + mConfig.detectorName + "-" + mName + std::to_string(mLayer) + "l-" + std::to_string(mId); |
Collaborator
There was a problem hiding this comment.
you could consider switching the order to comply with the order in QC
Collaborator
Author
|
@ktf I think that the fullCI error is spurrious. Could you confirm and merge ? |
Member
|
Yes, agreed. @davidrohr @shahor02 since a couple of days I see: was there any relevant change in FDD? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.