Skip to content

[QC-751] Remove obsolete QC flags #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barthelemy merged 1 commit into from
Apr 27, 2022
Merged

[QC-751] Remove obsolete QC flags #8651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions DataFormats/QualityControl/etc/flagReasons.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
"id","method","name","bad","obsolete"
1,"Unknown","Unknown",1,0
2,"ProcessingError","Processing Error",1,0
3,"MissingQualityObject","Missing Quality Object",1,0
4,"MissingQuality","Missing Quality",1,0
5,"UnknownQuality","Unknown Quality",1,0
6,"CertifiedByExpert","Certified by Expert",0,0
2,"UnknownQuality","Unknown Quality",1,0
3,"CertifiedByExpert","Certified by Expert",0,0
10,"NoDetectorData","No Detector Data",1,0
11,"LimitedAcceptance","Limited acceptance",1,0
12,"BadPID","Bad PID",1,0
Expand Down
8 changes: 4 additions & 4 deletions DataFormats/QualityControl/test/testTimeRangeFlag.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ using namespace o2::quality_control;

BOOST_AUTO_TEST_CASE(test_TimeRangeFlag)
{
TimeRangeFlag trf1{12, 34, FlagReasonFactory::ProcessingError(), "comment", "source"};
TimeRangeFlag trf1{12, 34, FlagReasonFactory::BadTracking(), "comment", "source"};

BOOST_CHECK_EQUAL(trf1.getStart(), 12);
BOOST_CHECK_EQUAL(trf1.getEnd(), 34);
BOOST_CHECK_EQUAL(trf1.getFlag(), FlagReasonFactory::ProcessingError());
BOOST_CHECK_EQUAL(trf1.getFlag(), FlagReasonFactory::BadTracking());
BOOST_CHECK_EQUAL(trf1.getComment(), "comment");
BOOST_CHECK_EQUAL(trf1.getSource(), "source");

BOOST_CHECK_THROW((TimeRangeFlag{12, 0, FlagReasonFactory::ProcessingError()}), std::runtime_error);
BOOST_CHECK_THROW((TimeRangeFlag{12, 0, FlagReasonFactory::BadTracking()}), std::runtime_error);

TimeRangeFlag trf2{10, 34, FlagReasonFactory::ProcessingError(), "comment", "source"};
TimeRangeFlag trf2{10, 34, FlagReasonFactory::BadTracking(), "comment", "source"};

BOOST_CHECK(trf1 > trf2);
BOOST_CHECK(!(trf1 < trf2));
Expand Down
4 changes: 2 additions & 2 deletions DataFormats/QualityControl/test/testTimeRangeFlagCollection.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ using namespace o2::quality_control;

BOOST_AUTO_TEST_CASE(test_TimeRangeFlagCollection_Methods)
{
TimeRangeFlag trf1{12, 34, FlagReasonFactory::ProcessingError(), "comment", "source"};
TimeRangeFlag trf2{10, 34, FlagReasonFactory::ProcessingError(), "comment", "source"};
TimeRangeFlag trf1{12, 34, FlagReasonFactory::BadTracking(), "comment", "source"};
TimeRangeFlag trf2{10, 34, FlagReasonFactory::BadTracking(), "comment", "source"};

TimeRangeFlagCollection trfc1{"Raw data checks", "TOF", {10, 20000}, 12345, "LHC22k5", "passMC", "qc_mc"};
trfc1.insert(trf1); // by copy
Expand Down