Fix for not throwing exception in cpv::RawReaderMemory when processin…

[sevdokim]

…g corrupted RDH
Hello @davidrohr @shahor02
This is a fix to catch exception which is thrown when reading corrupted cpv raw data.

[shahor02]

@sevdokim the

AliceO2/Detectors/CPV/reconstruction/src/RawReaderMemory.cxx

Line 59 in 3021046

RawErrorType_t RawReaderMemory::next()

will now detect the error and return a proper error code (w/o rethrowing) but the caller function does not check the returned value, it just catches exceptions.
You should check it and in case of error abandon the TF processing (still sending output to not block the workflow and logging corresponding message, like you do for the deadbeef).

[sevdokim]

Hi @shahor02
is it really necessary to abandon whole TF in case of bad rdh catched? Currently it just skips page with bad rdh and process the rest of TF.

[shahor02]

@sevdokim strictly speaking it is not necessary to skip whole TF, but RDH errors usually mean memory problems, likely the whole TF will be corrupted.
In any case, I don't see where do you skip the page with bad RDH: in

AliceO2/Detectors/CPV/workflow/src/RawToDigitConverterSpec.cxx

Line 129 in 3021046

rawreader.next();

you are not checking the return code of the next() and proceed to decoding unless the exception was caught, but it will not be caught there since you have a catch in the nextPage().

[sevdokim]

Hi @shahor02
you are absolutely right! Thank you very much for careful review of the code. Skipping of corrupted tf is implemented now. It seems to be working fine with randomly generated rdh versions.