Skip to content

fix: run prebuild-install only if actually used by the package#83

Merged
robertsLando merged 3 commits intoyao-pkg:mainfrom
segevfiner:only-run-prebuild-install-when-actually-used
Aug 14, 2024
Merged

fix: run prebuild-install only if actually used by the package#83
robertsLando merged 3 commits intoyao-pkg:mainfrom
segevfiner:only-run-prebuild-install-when-actually-used

Conversation

@segevfiner
Copy link
Copy Markdown

#80

@robertsLando robertsLando changed the title Only run prebuild-install if actually used by the package fix: run prebuild-install if actually used by the package Aug 14, 2024
Copy link
Copy Markdown
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title fix: run prebuild-install if actually used by the package fix: run prebuild-install only if actually used by the package Aug 14, 2024
@robertsLando robertsLando merged commit 2a046e4 into yao-pkg:main Aug 14, 2024
Vylpes pushed a commit to Vylpes/random-bunny that referenced this pull request Sep 10, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@yao-pkg/pkg](https://github.com/yao-pkg/pkg) | devDependencies | minor | [`5.12.0` -> `5.13.0`](https://renovatebot.com/diffs/npm/@yao-pkg%2fpkg/5.12.0/5.13.0) |

---

### Release Notes

<details>
<summary>yao-pkg/pkg (@&#8203;yao-pkg/pkg)</summary>

### [`v5.13.0`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5130-2024-09-06)

[Compare Source](yao-pkg/pkg@v5.12.1...v5.13.0)

##### Features

-   bump pkg-fetch@3.5.10 with node 20.17.0 and 18.20.4 support ([dda9032](yao-pkg/pkg@dda9032))

##### Bug Fixes

-   wrong placeholder replaced in windows binary ([#&#8203;86](yao-pkg/pkg#86)) ([d9b28c3](yao-pkg/pkg@d9b28c3))

### [`v5.12.1`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5121-2024-08-14)

[Compare Source](yao-pkg/pkg@v5.12.0...v5.12.1)

##### Bug Fixes

-   remove `is-core-module` dependency ([#&#8203;77](yao-pkg/pkg#77)) ([2f27414](yao-pkg/pkg@2f27414))
-   run prebuild-install only if actually used by the package ([#&#8203;83](yao-pkg/pkg#83)) ([2a046e4](yao-pkg/pkg@2a046e4))

##### Chores

-   drop package-lock file uploaded by error ([ba407ef](yao-pkg/pkg@ba407ef))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/216
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants