feat: use unofficial builds in SEA#126
Merged
robertsLando merged 1 commit intoyao-pkg:mainfrom Nov 22, 2024
Merged
Conversation
robertsLando
changed the title
robertsLando
requested changes
Nov 20, 2024
Member
robertsLando
left a comment
robertsLando
left a comment
There was a problem hiding this comment.
From a code POV looks good but please fix lint issues yarn fix
Member
|
ALso SEA test is failing now: https://github.com/yao-pkg/pkg/actions/runs/11928138559/job/33245882566?pr=126#step:7:34 |
hack3ric
force-pushed
the
more-archs-sea
branch
from
d71cbd8 to
ec12c5a
Compare
riscv64 and loong64 have unofficial builds at https://unofficial-builds.nodejs.org and can be used in SEA build. This is in conjunction with yao-pkg/pkg-fetch#62.
hack3ric
force-pushed
the
more-archs-sea
branch
from
ec12c5a to
24a350a
Compare
Author
|
Turns out |
Member
|
Thanks @hack3ric |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv64 and loong64 have unofficial builds at https://unofficial-builds.nodejs.org and can be used in SEA build.
This is in conjunction with yao-pkg/pkg-fetch#62.
Tested on real riscv64 hardware and it works fine.