fix(#3077): deleting a directory containing symlinked directory will delete the contents of the linked directory#3168
Merged
alex-courtis merged 2 commits intonvim-tree:masterfrom Jul 27, 2025
Conversation
… delete all content inside the symlink
alex-courtis
changed the title
alex-courtis
changed the title
alex-courtis
approved these changes
Jul 27, 2025
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Tested OK, also via sshfs
ln -sv $(pwd)/mnt $(pwd)/first-dir/mnt-symlink
Many thanks for your contribution!
Contributor
Author
|
No problem! This is my first public contribution) |
Member
Congrats! Big milestone... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #3077
The problem was that nvim-tree did not check if the file was a symlink, and the method
vim.loop.fs_stat(cwd)returns the filetype of the file that the symlink points to, not the type of file the symlink is. I simply added a checkvim.loop.fs_lstat(new_cwd), which returns an object with type == "link" if the file is a symlink.