fix(picker): exclude full_name window id from the choice

[przepompownia]

Problem: full_name window from is considered as usable by picker
Solution: exclude its ID (also true for nil values)

[alex-courtis]

Thanks for picking this one up. Unfortunately I'm not able to reproduce.

Attempted with:

{
  on_attach = M.on_attach,
  renderer = {
    full_name = true,
  },
  actions = {
    open_file = {
      window_picker = {
        enable = true,
        picker = "default",
        chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890",
        exclude = {
          -- filetype = { "notify", "packer", "qf", "diff", "fugitive", "fugitiveblame" },
          -- buftype = { "nofile", "terminal", "help" },
          filetype = { "foo" },
          buftype = { "bar" },
        },
      },
    },
  },
}

Terminal and empty windows were available, but not full_name

[przepompownia]

Please try with the only (except NvimTree) window. I can reproduce it with the below init file.

init.lua

local thisInitFile = debug.getinfo(1).source:match('@?(.*)')
local cwd = vim.fs.dirname(thisInitFile)
local appname = vim.env.NVIM_APPNAME or 'nvim'

vim.env.XDG_CONFIG_HOME = cwd
vim.env.XDG_DATA_HOME = vim.fs.joinpath(cwd, '.xdg', 'data')
vim.env.XDG_STATE_HOME = vim.fs.joinpath(cwd, '.xdg', 'state')
vim.env.XDG_CACHE_HOME = vim.fs.joinpath(cwd, '.xdg', 'cache')
vim.fn.mkdir(vim.fs.joinpath(vim.env.XDG_CACHE_HOME, appname), 'p')
local stdPathConfig = vim.fn.stdpath('config')

vim.opt.runtimepath:prepend(stdPathConfig)
vim.opt.packpath:prepend(stdPathConfig)

local function gitClone(url, installPath, branch)
  if vim.fn.isdirectory(installPath) ~= 0 then
    return
  end

  local command = {'git', 'clone', '--', url, installPath}
  if branch then
    table.insert(command, 3, '--branch')
    table.insert(command, 4, branch)
  end

  vim.notify(('Cloning %s dependency into %s...'):format(url, installPath), vim.log.levels.INFO, {})
  local sysObj = vim.system(command, {}):wait()
  if sysObj.code ~= 0 then
    error(sysObj.stderr)
  end
  vim.notify(sysObj.stdout)
  vim.notify(sysObj.stderr, vim.log.levels.WARN)
end

local pluginsPath = vim.fs.joinpath(cwd, 'nvim/pack/plugins/opt')
vim.fn.mkdir(pluginsPath, 'p')
pluginsPath = vim.uv.fs_realpath(pluginsPath)

--- @type table<string, {url:string, branch: string?}>
local plugins = {
  ['nvim-tree'] = {url = 'https://github.com/przepompownia/nvim-tree.lua'},
}

for name, repo in pairs(plugins) do
  local installPath = vim.fs.joinpath(pluginsPath, name)
  gitClone(repo.url, installPath, repo.branch)
  vim.opt.runtimepath:append(installPath)
  -- vim.cmd.packadd({args = {name}, bang = true})
end

vim.api.nvim_create_autocmd('UIEnter', {
  once = true,
  callback = function ()
    require('nvim-tree').setup({
      actions = {
        open_file = {
          window_picker = {
            exclude = {
              buftype = {'prompt'},
            },
          },
        },
      },
      renderer = {
        full_name = true,
      },
    })
    require('nvim-tree.api').tree.open()
  end,
})

[alex-courtis]

Please try with the only (except NvimTree) window. I can reproduce it with the below init file.

I can replicate, thank you.

Under the default configuration buftype = { "nofile" excludes the full-name window.

There are use cases for removing "nofile", however no use cases for opening in the full-name window.

This change works beautifully, many thanks for your contribution!

[alex-courtis]

The CI failure is also on master. I'll fix it there, rebase this branch, then merge.

[przepompownia]

Ah, I missed the CI failure. Thank you for the fix and merge. I've been AFK for the past few days.

[alex-courtis]

Ah, I missed the CI failure. Thank you for the fix and merge. I've been AFK for the past few days.

No worries.

I've invited you as a member of this repo for easier future PRs; you can push branches here.

[przepompownia]

Nice to see, although I have too little attention and time for active contribution so I expect to continue occasional contribution as before.