Skip to content

Comments

tests for npm doctor#2323

Merged
isaacs merged 1 commit intorelease/v7.1.2from
nlf/doctor-tests
Dec 11, 2020
Merged

tests for npm doctor#2323
isaacs merged 1 commit intorelease/v7.1.2from
nlf/doctor-tests

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Dec 10, 2020

also removed a default parameter that caused a coverage problem (we always pass a value), and made ping errors always throw a string since that is how the error value is consumed later.

References

Closes npm/statusboard#148

@nlf nlf requested a review from a team as a code owner December 10, 2020 17:47
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 11, 2020
@nlf @isaacs
tests for npm doctor
7a4f0c9 
PR-URL: #2323
Credit: @nlf
Close: #2323
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.1.2 December 11, 2020 19:33
@isaacs isaacs merged commit 7a4f0c9 into release/v7.1.2 Dec 11, 2020
@isaacs isaacs mentioned this pull request Dec 11, 2020
Merged
This was referenced Dec 11, 2020
Closed
Closed
@nlf nlf deleted the nlf/doctor-tests branch March 28, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darcyclarke darcyclarke darcyclarke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v7(tests): doctor

3 participants

@nlf @darcyclarke @isaacs