minor cleanup of completion command and add tests#2313
Merged
isaacs merged 1 commit intorelease/v7.1.2from Dec 11, 2020
Merged
Conversation
nlf
force-pushed
the
nlf/completion-tests
branch
from
22766d6 to
979a6d3
Compare
ruyadorno
added
Release 7.x
isaacs
force-pushed
the
nlf/completion-tests
branch
from
979a6d3 to
c243e3b
Compare
Merged
This was referenced Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i removed all of the
console.error()calls from the completion command, which were very clearly used for debugging purposes and went unnoticed thanks to having no tests and the fact that the shell only cares about stdout for real usageReferences
Closes npm/statusboard#144