fix: remove unsafe remove of install folder#372
Merged
merceyz merged 3 commits intonodejs:mainfrom Feb 11, 2024
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
merceyz
changed the title
merceyz
force-pushed
the
merceyz/fix/remove-unsafe-remove
branch
from
5f7b1c1 to
0f66d1b
Compare
merceyz
force-pushed
the
merceyz/fix/remove-unsafe-remove
branch
from
0f66d1b to
a8f8736
Compare
merceyz
changed the title
aduh95
reviewed
Feb 10, 2024
aduh95
reviewed
Feb 10, 2024
Comment on lines
+26
to
+31
| export function getInstallFolder() { | ||
| return join( | ||
| getCorepackHomeFolder(), | ||
| `v${INSTALL_FOLDER_VERSION}`, | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
This is going to invalidate all cache from existing installation, without removing it from disk, right?
Member
Author
There was a problem hiding this comment.
Correct, we should add some clean-up in a follow-up PR.
aduh95
approved these changes
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#291 introduced an unsafe remove which sometimes break parallel installs.