feat: include chrome healthcheck

AVVS · AVVS · commit 7ce4741fd597 · 2019-07-24T11:22:14.000-07:00
diff --git a/__tests__/unit/render.spec.js b/__tests__/unit/render.spec.js
@@ -1,7 +1,11 @@
-const Printer = require('../../src');
-const amqpConfig = require('../configs/amqp');
+const request = require('request-promise').defaults({
+  baseUrl: 'http://localhost:3000',
+});
+
+describe('render action', () => {
+  const Printer = require('../../src');
+  const amqpConfig = require('../configs/amqp');
 
-describe('render action', async () => {
   let service;
   let amqpClient;
 
@@ -85,6 +89,10 @@ describe('render action', async () => {
     expect(data).toMatch(/^[0-9A-F]{8}-[0-9A-F]{4}-4[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}$/i);
   });
 
+  it('healh check should return successful response', async () => {
+    await request.get('/generic/health');
+  });
+
   afterAll(async () => {
     await service.close();
   });
diff --git a/src/configs/amqp.js b/src/configs/amqp.js
@@ -24,6 +24,7 @@ exports.amqp = {
   },
   router: {
     enabled: true,
+    prefix: 'pdf',
   },
   retry: {
     enabled: true,
diff --git a/src/configs/http.js b/src/configs/http.js
@@ -9,5 +9,6 @@ exports.http = {
   },
   router: {
     enabled: true,
+    prefix: '',
   },
 };
diff --git a/src/configs/router.js b/src/configs/router.js
@@ -25,7 +25,6 @@ const metrics = routerExtension('audit/metrics');
 exports.router = {
   routes: {
     directory: path.resolve(__dirname, '../actions'),
-    prefix: 'pdf',
     setTransportsAsDefault: false,
     transports: [ActionTransport.amqp, ActionTransport.http],
     enabledGenericActions: ['health'],
diff --git a/src/index.js b/src/index.js
@@ -1,4 +1,5 @@
 const { Microfleet, ConnectorsTypes } = require('@microfleet/core');
+const { PluginHealthCheck } = require('@microfleet/core/lib/utils/pluginHealthStatus');
 const merge = require('lodash/merge');
 
 const Mustache = require('./utils/mustache');
@@ -39,5 +40,6 @@ module.exports = class PdfPrinter extends Microfleet {
     // add connectors & disconnectors
     this.addConnector(ConnectorsTypes.essential, chrome.init.bind(chrome));
     this.addDestructor(ConnectorsTypes.essential, chrome.kill.bind(chrome));
+    this.addHealthCheck(new PluginHealthCheck('chrome', chrome.status.bind(chrome)));
   }
 };
diff --git a/src/utils/chrome.js b/src/utils/chrome.js
@@ -3,10 +3,12 @@ const noop = require('lodash/noop');
 const ChromeRemote = require('chrome-remote-interface');
 const { encode } = require('64');
 const { Launcher } = require('chrome-launcher');
+const { HttpStatusError } = require('common-errors');
 
 const debug = require('debug')('ms-printer:chrome');
 
 const _SIGINT = 'SIGINT';
+const kStatusCheckHTML = '<html><head><title>status</title></head><body></body></html>';
 
 class Chrome {
   /**
@@ -30,7 +32,7 @@ class Chrome {
   constructor(opts = {}) {
     const {
       logger,
-      timeout = 10000,
+      timeout = 7500,
       ...restOpts
     } = opts;
 
@@ -40,7 +42,7 @@ class Chrome {
     // settings
     this.settings = Object.assign({
       logLevel: 'info',
-      port: 9222,
+      port: 0, // generates random port
       chromeFlags: [
         '--window-size=1024,768',
         '--disable-gpu',
@@ -85,13 +87,42 @@ class Chrome {
    * @returns {Promise<null>}
    */
   async kill() {
+    const { launcher } = this;
+
     // kill chrome instance if has been launched
-    if (this.launcher) {
-      await this.launcher.kill();
+    if (launcher) {
+      this.launcher = null;
+      await launcher.kill();
     }
+  }
 
-    this.launcher = null;
-    return null;
+  async status(attempt = 0) {
+    this.log.debug('evaluating chrome health');
+
+    if (this.launcher == null) {
+      throw new HttpStatusError(502, 'chrome not started');
+    }
+
+    try {
+      await this.printToPdf(kStatusCheckHTML);
+      return true;
+    } catch (e) {
+      this.log.warn({ err: e }, 'failed chrome status check');
+      if (attempt > 0) {
+        throw new HttpStatusError(504, `failed to open tab: ${e.message}`);
+      }
+    }
+
+    try {
+      this.log.warn('restarting chrome due to a healthcheck error');
+      await Promise.all([this.kill(), this.init()]);
+    } catch (e) {
+      this.log.fatal({ err: e }, 'failed to restart chrome');
+      throw new HttpStatusError(500, 'failed to restart chrome');
+    }
+
+    // do a second attempt after restart
+    return this.status(1);
   }
 
   /**
