Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Commit bb5e71d

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#215)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: https://github.com/googleapis/googleapis-gen/commit/b3f18d0f6560a855022fd058865e7620479d7af9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 1030a7e commit bb5e71d

File tree

9 files changed

+15
-47
lines changed

9 files changed

+15
-47
lines changed

‎google/cloud/binaryauthorization_v1/services/binauthz_management_service_v1/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,7 @@ async def sample_delete_attestor():
11091109
metadata=metadata,
11101110
)
11111111

1112-
async def __aenter__(self):
1112+
async def __aenter__(self) -> "BinauthzManagementServiceV1AsyncClient":
11131113
return self
11141114

11151115
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/binaryauthorization_v1/services/system_policy_v1/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ async def sample_get_system_policy():
319319
# Done; return the response.
320320
return response
321321

322-
async def __aenter__(self):
322+
async def __aenter__(self) -> "SystemPolicyV1AsyncClient":
323323
return self
324324

325325
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/binaryauthorization_v1/services/validation_helper_v1/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ async def sample_validate_attestation_occurrence():
297297
# Done; return the response.
298298
return response
299299

300-
async def __aenter__(self):
300+
async def __aenter__(self) -> "ValidationHelperV1AsyncClient":
301301
return self
302302

303303
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/binaryauthorization_v1beta1/services/binauthz_management_service_v1_beta1/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1122,7 +1122,7 @@ async def sample_delete_attestor():
11221122
metadata=metadata,
11231123
)
11241124

1125-
async def __aenter__(self):
1125+
async def __aenter__(self) -> "BinauthzManagementServiceV1Beta1AsyncClient":
11261126
return self
11271127

11281128
async def __aexit__(self, exc_type, exc, tb):

‎google/cloud/binaryauthorization_v1beta1/services/system_policy_v1_beta1/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ async def sample_get_system_policy():
321321
# Done; return the response.
322322
return response
323323

324-
async def __aenter__(self):
324+
async def __aenter__(self) -> "SystemPolicyV1Beta1AsyncClient":
325325
return self
326326

327327
async def __aexit__(self, exc_type, exc, tb):

‎samples/generated_samples/snippet_metadata_google.cloud.binaryauthorization.v1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-binary-authorization",
11-
"version": "1.6.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎samples/generated_samples/snippet_metadata_google.cloud.binaryauthorization.v1beta1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-binary-authorization",
11-
"version": "1.6.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎tests/unit/gapic/binaryauthorization_v1/test_binauthz_management_service_v1.py‎

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1265,9 +1265,6 @@ def test_create_attestor(request_type, transport: str = "grpc"):
12651265
call.return_value = resources.Attestor(
12661266
name="name_value",
12671267
description="description_value",
1268-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
1269-
note_reference="note_reference_value"
1270-
),
12711268
)
12721269
response = client.create_attestor(request)
12731270

@@ -1520,9 +1517,6 @@ def test_get_attestor(request_type, transport: str = "grpc"):
15201517
call.return_value = resources.Attestor(
15211518
name="name_value",
15221519
description="description_value",
1523-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
1524-
note_reference="note_reference_value"
1525-
),
15261520
)
15271521
response = client.get_attestor(request)
15281522

@@ -1755,9 +1749,6 @@ def test_update_attestor(request_type, transport: str = "grpc"):
17551749
call.return_value = resources.Attestor(
17561750
name="name_value",
17571751
description="description_value",
1758-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
1759-
note_reference="note_reference_value"
1760-
),
17611752
)
17621753
response = client.update_attestor(request)
17631754

@@ -2379,9 +2370,11 @@ async def test_list_attestors_async_pages():
23792370
RuntimeError,
23802371
)
23812372
pages = []
2382-
async for page_ in (
2373+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
2374+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
2375+
async for page_ in ( # pragma: no branch
23832376
await client.list_attestors(request={})
2384-
).pages: # pragma: no branch
2377+
).pages:
23852378
pages.append(page_)
23862379
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
23872380
assert page_.raw_page.next_page_token == token
@@ -3218,9 +3211,6 @@ def test_create_attestor_rest(request_type):
32183211
return_value = resources.Attestor(
32193212
name="name_value",
32203213
description="description_value",
3221-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
3222-
note_reference="note_reference_value"
3223-
),
32243214
)
32253215

32263216
# Wrap the value into a proper Response obj
@@ -3534,9 +3524,6 @@ def test_get_attestor_rest(request_type):
35343524
return_value = resources.Attestor(
35353525
name="name_value",
35363526
description="description_value",
3537-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
3538-
note_reference="note_reference_value"
3539-
),
35403527
)
35413528

35423529
# Wrap the value into a proper Response obj
@@ -3819,9 +3806,6 @@ def test_update_attestor_rest(request_type):
38193806
return_value = resources.Attestor(
38203807
name="name_value",
38213808
description="description_value",
3822-
user_owned_grafeas_note=resources.UserOwnedGrafeasNote(
3823-
note_reference="note_reference_value"
3824-
),
38253809
)
38263810

38273811
# Wrap the value into a proper Response obj

‎tests/unit/gapic/binaryauthorization_v1beta1/test_binauthz_management_service_v1_beta1.py‎

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1277,9 +1277,6 @@ def test_create_attestor(request_type, transport: str = "grpc"):
12771277
call.return_value = resources.Attestor(
12781278
name="name_value",
12791279
description="description_value",
1280-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
1281-
note_reference="note_reference_value"
1282-
),
12831280
)
12841281
response = client.create_attestor(request)
12851282

@@ -1532,9 +1529,6 @@ def test_get_attestor(request_type, transport: str = "grpc"):
15321529
call.return_value = resources.Attestor(
15331530
name="name_value",
15341531
description="description_value",
1535-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
1536-
note_reference="note_reference_value"
1537-
),
15381532
)
15391533
response = client.get_attestor(request)
15401534

@@ -1767,9 +1761,6 @@ def test_update_attestor(request_type, transport: str = "grpc"):
17671761
call.return_value = resources.Attestor(
17681762
name="name_value",
17691763
description="description_value",
1770-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
1771-
note_reference="note_reference_value"
1772-
),
17731764
)
17741765
response = client.update_attestor(request)
17751766

@@ -2391,9 +2382,11 @@ async def test_list_attestors_async_pages():
23912382
RuntimeError,
23922383
)
23932384
pages = []
2394-
async for page_ in (
2385+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
2386+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
2387+
async for page_ in ( # pragma: no branch
23952388
await client.list_attestors(request={})
2396-
).pages: # pragma: no branch
2389+
).pages:
23972390
pages.append(page_)
23982391
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
23992392
assert page_.raw_page.next_page_token == token
@@ -3231,9 +3224,6 @@ def test_create_attestor_rest(request_type):
32313224
return_value = resources.Attestor(
32323225
name="name_value",
32333226
description="description_value",
3234-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
3235-
note_reference="note_reference_value"
3236-
),
32373227
)
32383228

32393229
# Wrap the value into a proper Response obj
@@ -3549,9 +3539,6 @@ def test_get_attestor_rest(request_type):
35493539
return_value = resources.Attestor(
35503540
name="name_value",
35513541
description="description_value",
3552-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
3553-
note_reference="note_reference_value"
3554-
),
35553542
)
35563543

35573544
# Wrap the value into a proper Response obj
@@ -3834,9 +3821,6 @@ def test_update_attestor_rest(request_type):
38343821
return_value = resources.Attestor(
38353822
name="name_value",
38363823
description="description_value",
3837-
user_owned_drydock_note=resources.UserOwnedDrydockNote(
3838-
note_reference="note_reference_value"
3839-
),
38403824
)
38413825

38423826
# Wrap the value into a proper Response obj

0 commit comments

Comments
 (0)