Skip to content

feat(bigquery): add support for session in load jobs#7418

Merged
alvarowolfx merged 5 commits intogoogleapis:mainfrom
alvarowolfx:bq-load-session-job
Feb 17, 2023
Merged

feat(bigquery): add support for session in load jobs#7418
alvarowolfx merged 5 commits intogoogleapis:mainfrom
alvarowolfx:bq-load-session-job

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Towards internal b/268630262

@alvarowolfx alvarowolfx requested review from a team, Neenu1995 and shollyman February 13, 2023 22:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Feb 13, 2023
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but please take a quick pass through our various doc comments to ensure we're adequately capturing the new usage of sessions and connection properties.

For example, https://github.com/googleapis/google-cloud-go/blob/main/bigquery/query.go#L490 describes ConnectionProperty only in the context of a query request, and this changes it to be a load or query.

@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Feb 14, 2023
@shollyman shollyman removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 14, 2023
@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2023
@alvarowolfx alvarowolfx merged commit f9ff2ca into googleapis:main Feb 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants