Skip to content

fix: return impersonated token as lastReceivedToken#606

Merged
bshaffer merged 3 commits intomainfrom
fix-get-last-received-token-for-impersonated-tokens
Feb 5, 2025
Merged

fix: return impersonated token as lastReceivedToken#606
bshaffer merged 3 commits intomainfrom
fix-get-last-received-token-for-impersonated-tokens

Conversation

@bshaffer
Copy link
Copy Markdown
Contributor

@bshaffer bshaffer commented Feb 4, 2025

No description provided.

@mruell
Copy link
Copy Markdown

mruell commented Feb 5, 2025

(related: #605)

Looks good to me, only were thinking about setting lastImpersonatedAccessToken to null first in fetchAuthToken, in case a later call does not have serviceAccountImpersonationUrl.

But I guess this case shouldn't be possible, so this should be fine

Thanks a lot and best!

@bshaffer
Copy link
Copy Markdown
Contributor Author

bshaffer commented Feb 5, 2025

in case a later call does not have serviceAccountImpersonationUrl.

The null-coalescing (??) operator will return false if the variable hasn't been initialized, so this case is covered!

Thanks for your review

Copy link
Copy Markdown

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer merged commit 33c3c85 into main Feb 5, 2025
13 checks passed
@bshaffer bshaffer deleted the fix-get-last-received-token-for-impersonated-tokens branch February 5, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants