feat: Change getCacheKey implementation for more unique keys#560
Merged
feat: Change getCacheKey implementation for more unique keys#560
Conversation
Hectorhammett
force-pushed
the
remove-oauth-dependency
branch
3 times, most recently
from
6ccea31 to
126d7ec
Compare
Hectorhammett
force-pushed
the
remove-oauth-dependency
branch
from
126d7ec to
4317d4f
Compare
bshaffer
reviewed
Jun 6, 2024
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
Good job! I think we can improve a few things. Additionally, I'd like to see PHPDoc comments for the getCacheKey method which explains which fields are included in the cache key.
Hectorhammett
force-pushed
the
remove-oauth-dependency
branch
from
a0dc04d to
8415d95
Compare
bshaffer
reviewed
Jun 13, 2024
Contributor
|
@westarle We are looking to merge this soon, and would love you to take a look! |
bshaffer
reviewed
Jun 28, 2024
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
nits and minor suggestions only!
bshaffer
reviewed
Jul 3, 2024
bshaffer
reviewed
Jul 9, 2024
bshaffer
approved these changes
Jul 10, 2024
bshaffer
reviewed
Jul 10, 2024
| return ($this->imdsv2SessionTokenUrl ?? '') . | ||
| '.' . ($this->securityCredentialsUrl ?? '') . | ||
| '.' . $this->regionUrl . | ||
| '.' . $this->regionalCredVerificationUrl; |
Contributor
There was a problem hiding this comment.
I just had a thought... one way you could get rid of the . without having a separate function is to do something like this:
return implode('.', array_filter([
$this->imdsv2SessionTokenUrl,
$this->securityCredentialsUrl,
$this->regionUrl,
$this->regionalCredVerificationUrl
]));But I don't think that's necessary... what we have here looks LGTM to me
Contributor
Author
There was a problem hiding this comment.
Brent, you a genius, I do like that better haha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made changes to how we calculate the
cacheKeysin order to avoid collision for the oncoming support for the Caching update.closes: #559