feat: add ID tokens for user refresh credentials#468
Merged
Conversation
4 tasks
Hectorhammett
approved these changes
Oct 24, 2024
| throw new \InvalidArgumentException('file does not exist'); | ||
| throw new InvalidArgumentException('file does not exist'); | ||
| } | ||
| $json = file_get_contents($jsonKey); |
Contributor
There was a problem hiding this comment.
file_get_contents can return a false value on error. Should we take that into consideration?
Contributor
Author
There was a problem hiding this comment.
yes, that's a good point... maybe it should be file does not exist or is unreadable instead
| } | ||
| if ($scope && $targetAudience) { | ||
| throw new InvalidArgumentException( | ||
| 'Scope and targetAudience cannot both be supplied' |
Contributor
bshaffer
commented
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add ID token support to
UserRefreshCredentialsManually tested by running
gcloud auth application-default login, and then executing the following:see also googleapis/google-auth-library-nodejs#1811