feat: implement quota project from env var in google/auth#452
Merged
Conversation
Contributor
Author
|
reopened at the request of @sai-sunder-s |
sai-sunder-s
approved these changes
May 1, 2023
bshaffer
commented
May 2, 2023
sai-sunder-s
approved these changes
May 2, 2023
Contributor
|
It appears that if
|
Contributor
Author
I do not think setting quotaProject is required anywhere.
Removing it would definitely be breaking. Also we don't want to remove it. There is no "preferred", it's just that in some situations a user might want to use an env var, and in some situations a parameter.
In the case that both are set, the parameter is used. I'm all for adding clarity on this, and will add documentation to reflect this. |
ajupazhamayil
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.