fix: do not call GCECredentials::onGCE if ADC has already checked#422
Merged
fix: do not call GCECredentials::onGCE if ADC has already checked#422
Conversation
dwsupplee
suggested changes
Oct 21, 2022
dwsupplee
approved these changes
Oct 25, 2022
Contributor
dwsupplee
left a comment
There was a problem hiding this comment.
LGTM, just also raising up the PHPStan failure if you'd like to address that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method
GCECredentials::setIsOnGce, so that ifApplicationDefaultCredentialsalready checks that the library is running on GCE, we do not need to check again inGCECredentials.