From 3ceb10de4121e69671da9837d42bf39b992eaa98 Mon Sep 17 00:00:00 2001 From: Kenzie Davisson Date: Thu, 17 Apr 2025 10:22:07 -0700 Subject: [PATCH 1/2] Skip simple_items_test.dart for customer tests --- .../test/shared/primitives/simple_items_test.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/test/shared/primitives/simple_items_test.dart b/packages/devtools_app/test/shared/primitives/simple_items_test.dart index 2dc161fae64..ad6ae52b7ca 100644 --- a/packages/devtools_app/test/shared/primitives/simple_items_test.dart +++ b/packages/devtools_app/test/shared/primitives/simple_items_test.dart @@ -3,6 +3,7 @@ // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. import 'package:devtools_app/src/shared/primitives/simple_items.dart'; +import 'package:devtools_test/helpers.dart'; import 'package:flutter_test/flutter_test.dart'; import '../../test_infra/utils/test_utils.dart'; @@ -15,6 +16,9 @@ void main() { if (hash != null) { expect(content, contains('href="#$hash"')); } - }); + }, + // This test hits the network, which is a violation of Flutter customer + // tests policy: https://github.com/flutter/tests?tab=readme-ov-file#adding-more-tests. + tags: skipForCustomerTestsTag); } } From 8f3acbcb5cba4c5a6a6e61937979d5bce9be474c Mon Sep 17 00:00:00 2001 From: Kenzie Davisson Date: Thu, 17 Apr 2025 11:01:44 -0700 Subject: [PATCH 2/2] formatting --- .../shared/primitives/simple_items_test.dart | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/packages/devtools_app/test/shared/primitives/simple_items_test.dart b/packages/devtools_app/test/shared/primitives/simple_items_test.dart index ad6ae52b7ca..0426182aaa3 100644 --- a/packages/devtools_app/test/shared/primitives/simple_items_test.dart +++ b/packages/devtools_app/test/shared/primitives/simple_items_test.dart @@ -10,15 +10,18 @@ import '../../test_infra/utils/test_utils.dart'; void main() { for (final link in DocLinks.values) { - test('$link is not broken', () async { - final content = await loadPageHtmlContent(link.value); - final hash = link.hash; - if (hash != null) { - expect(content, contains('href="#$hash"')); - } - }, - // This test hits the network, which is a violation of Flutter customer - // tests policy: https://github.com/flutter/tests?tab=readme-ov-file#adding-more-tests. - tags: skipForCustomerTestsTag); + test( + '$link is not broken', + () async { + final content = await loadPageHtmlContent(link.value); + final hash = link.hash; + if (hash != null) { + expect(content, contains('href="#$hash"')); + } + }, + // This test hits the network, which is a violation of Flutter customer + // tests policy: https://github.com/flutter/tests?tab=readme-ov-file#adding-more-tests. + tags: skipForCustomerTestsTag, + ); } }