Fix ASM frame crash in atan2 and exists/delete operators#298
Merged
Conversation
Follow-up to PR #297: Apply the same spill pattern to additional operators that were missing it: - atan2 function - e.g., atan2(0, CONST) - exists/delete with compound dereference - e.g., exists $h{key}[CONST] These operators were not spilling their left operand before evaluating the right side, causing "Incompatible stack heights" errors when the RHS was a constant sub call. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <noreply@cognition.ai>
- Add warnFlag field to CompilerOptions for -w flag
- Set $^W=1 at initialization time instead of prepending BEGIN block
- Remove "use warnings" prepending for -w (only $^W needed)
- This fixes line number offset in warning messages
- Refactor $^W access to use GlobalContext.encodeSpecialVar("W")
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <noreply@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #297: Apply the same spill pattern to additional operators that were missing it.
Fixed operators:
atan2function - e.g.,atan2(0, CONST)exists/deletewith compound dereference - e.g.,exists $h{key}[CONST]Root cause: These operators were not spilling their left operand before evaluating the right side, causing "Incompatible stack heights" errors when the RHS was a constant sub call.
Test plan
atan2(0, CONST)no longer crashesexists $h{key}[CONST]no longer crashesGenerated with Devin