refactor: ignore-stderr

Author: atian25

README.md

@@ -54,7 +54,7 @@ $ eggctl start [options] [baseDir]
   - `stdout` - customize stdout file, default to `$HOME/logs/master-stdout.log`.
   - `stderr` - customize stderr file, default to `$HOME/logs/master-stderr.log`.
   - `timeout` - the maximum timeout when app starts, default to 300s.
-  - `ignore-error` - whether ignore stderr when app starts.
+  - `ignore-stderr` - whether ignore stderr when app starts.
 
 ### stop
 

lib/cmd/start.js

@@ -59,7 +59,7 @@ class StartCommand extends Command {
         type: 'number',
         default: 300 * 1000,
       },
-      'ignore-error': {
+      'ignore-stderr': {
         description: 'whether ignore stderr when app starts',
         type: 'boolean',
       },
@@ -132,7 +132,7 @@ class StartCommand extends Command {
     this.logger.info('Starting %s application at %s', this.frameworkName, baseDir);
 
     // remove unused properties from stringify, alias had been remove by `removeAlias`
-    const ignoreKeys = [ '_', '$0', 'env', 'daemon', 'stdout', 'stderr', 'timeout', 'ignore-error' ];
+    const ignoreKeys = [ '_', '$0', 'env', 'daemon', 'stdout', 'stderr', 'timeout', 'ignore-stderr' ];
     const eggArgs = [ this.serverBin, stringify(argv, ignoreKeys), `--title=${argv.title}` ];
     this.logger.info('Run node %s', eggArgs.join(' '));
 
@@ -181,7 +181,7 @@ class StartCommand extends Command {
     return name;
   }
 
-  * checkStatus({ stderr, timeout, 'ignore-error': ignoreError }) {
+  * checkStatus({ stderr, timeout, 'ignore-stderr': ignoreStdErr }) {
     let count = 0;
     let hasError = false;
     let isSuccess = true;
@@ -214,7 +214,7 @@ class StartCommand extends Command {
       } catch (_) {
         // nothing
       }
-      isSuccess = ignoreError;
+      isSuccess = ignoreStdErr;
       this.logger.error('Start got error, see %s', stderr);
     }