Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] atomic: patch 64bit alignment on 32bit systems#363

Merged
kolyshkin merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_64align
Sep 18, 2019
Merged

[19.03 backport] atomic: patch 64bit alignment on 32bit systems#363
kolyshkin merged 1 commit intodocker-archive:19.03from
thaJeztah:19.03_backport_64align

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 16, 2019

backport of moby#39543
fixes moby/buildkit#1079 Docker 18.09.7 nil pointer panic in builder-next/adapters/containerimage.(*cachedResolver).Resolve

causes panic on armv7

causes panic on armv7

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit af2e82d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.3 milestone Sep 16, 2019
@thaJeztah
Copy link
Member Author

@AkihiroSuda @tonistiigi ptal

Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link

It's a pity we don't have CI for ARM running (as far as I can see), but the change looks reasonable and minor. Merging

@kolyshkin kolyshkin merged commit 2b10608 into docker-archive:19.03 Sep 18, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_64align branch September 18, 2019 08:40
@thaJeztah
Copy link
Member Author

@kolyshkin see moby#39678

@thaJeztah
Copy link
Member Author

oh, that's arm64 of course

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants