This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Return "invalid parameter" when linking to non-existing container#352
Merged
andrewhsu merged 1 commit intodocker-archive:19.03from Sep 20, 2019
Conversation
Trying to link to a non-existing container is not valid, and should return an "invalid parameter" (400) error. Returning a "not found" error in this situation would make the client report the container's image could not be found. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 422067b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Windows RS1 https://ci.docker.com/public/job/engine/job/PR-352/1/execution/node/169/log/?consoleFull No idea on this one; it was flaky a few times in the past; https://github.com/moby/moby/search?q=TestAPIStatsNetworkStats&type=Issues. Other failure on RS1 is a known flaky issue moby#38521, and for which there's a WIP PR (that stalled unfortunately); moby#38595 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby#39852 to fix the regression in 19.03
fixes moby#39823
fixes docker/for-mac#3871
Trying to link to a non-existing container is not valid, and should return an
"invalid parameter" (400) error. Returning a "not found" error in this situation
would make the client report the container's image could not be found.