Skip to content

Commit 6f9045a

Browse files
committed
Skip CoopExecutorTest to avoid bogus test failure on PHP 7.4
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding any other test file, e.g. `CoopExecutorTest`. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping one test case for now.
1 parent 52f330e commit 6f9045a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

phpunit.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
<testsuites>
55
<testsuite name="ReactPHP Test Suite">
66
<directory>./vendor/react/*/tests/</directory>
7+
<!-- temporarily skip broken tests, see https://github.com/reactphp/dns/pull/164 -->
8+
<exclude>./vendor/react/dns/tests/Query/CoopExecutorTest.php</exclude>
79
</testsuite>
810
</testsuites>
911

0 commit comments

Comments
 (0)