Skip to content

fix: prevent infinite loop in _wait_for_finish on persistent 404s #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Feb 17, 2026
+6 −2
Merged

fix: prevent infinite loop in _wait_for_finish on persistent 404s #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/apify_client/clients/base/actor_job_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ def _wait_for_finish(self, wait_secs: int | None = None) -> dict | None:
)
job = parse_date_fields(pluck_data(response.json()))

seconds_elapsed = math.floor((datetime.now(timezone.utc) - started_at).total_seconds())
if ActorJobStatus(job['status']).is_terminal or (
wait_secs is not None and seconds_elapsed >= wait_secs
):
Expand All @@ -57,6 +56,9 @@ def _wait_for_finish(self, wait_secs: int | None = None) -> dict | None:
if seconds_elapsed > DEFAULT_WAIT_WHEN_JOB_NOT_EXIST_SEC:
return None

finally:
seconds_elapsed = math.floor((datetime.now(timezone.utc) - started_at).total_seconds())

# It might take some time for database replicas to get up-to-date so sleep a bit before retrying
time.sleep(0.25)

Expand Down Expand Up @@ -93,7 +95,6 @@ async def _wait_for_finish(self, wait_secs: int | None = None) -> dict | None:
)
job = parse_date_fields(pluck_data(response.json()))

seconds_elapsed = math.floor((datetime.now(timezone.utc) - started_at).total_seconds())
if ActorJobStatus(job['status']).is_terminal or (
wait_secs is not None and seconds_elapsed >= wait_secs
):
Expand All @@ -111,6 +112,9 @@ async def _wait_for_finish(self, wait_secs: int | None = None) -> dict | None:
if seconds_elapsed > DEFAULT_WAIT_WHEN_JOB_NOT_EXIST_SEC:
return None

finally:
seconds_elapsed = math.floor((datetime.now(timezone.utc) - started_at).total_seconds())

# It might take some time for database replicas to get up-to-date so sleep a bit before retrying
await asyncio.sleep(0.25)

Expand Down