fix: panel position in positioned container (#763)#1336
fix: panel position in positioned container (#763)#1336Haroenv merged 2 commits intoalgolia:nextfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09abe19:
|
|
Can you share your code in a reproducible example so we can see what side effect caused this? I'm having a hard time trying to reproduce your situation @alcohol |
|
That's going to be difficult. You can find the search on https://polyestershoppen.nl (or .com for english). But to extract this into a reproducible template.. oef.. this website is a nightmare html/css wise. Over a decade of spaghetti patching 😢 |
|
@alcohol this broke our layout in the exact same way. The fix that I was able to implement was to use the same ref for the autocomplete |
|
I've tried to reproduce and find a solution that still fixes @salomvary's original issue, but wasn't able to. If someone would like to find a solution that would work for all these use cases, I'll merge it right away :) |
|
@bryantee cheers for that! That solves our issue as well. |
The PRs #1338 and #1336 were very promising, but caused some regressions in positioned containers. Therefore for now i'll revert them. @salomvary, if you could reimplement these changes, but taking the relative positioning in account, that would be ideal. fixes #1342
The PRs #1338 and #1336 were very promising, but caused some regressions in positioned containers. Therefore for now i'll revert them. @salomvary, if you could reimplement these changes, but taking the relative positioning in account, that would be ideal. fixes #1342


Closes #763
Summary
Fix computing panel position and width when autocomplete is placed inside a positioned element.
Result
I've added an example to demonstrate the fix. It is in a separate commit so that it can easily be removed if this does not deserve a dedicated example.