fix(autocomplete-core): don't update enterKeyHint on Samsung Browser#1153
Merged
FabienMotte merged 1 commit intonextfrom Jun 7, 2023
Merged
fix(autocomplete-core): don't update enterKeyHint on Samsung Browser#1153FabienMotte merged 1 commit intonextfrom
enterKeyHint on Samsung Browser#1153FabienMotte merged 1 commit intonextfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0dba51e:
|
francoischalifour
approved these changes
Jun 7, 2023
Haroenv
approved these changes
Jun 7, 2023
Contributor
|
Maybe only samsungbrowser is needed, but happy to keep a larger target |
Contributor
Author
Some tests are not passing anymore, also we need to check for Samsung devices (and not only Samsung browser) since the issue is related to Samsung Predictive Search. Thanks for your reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CR-3619
This PR follows #916 and updates the
isSamsung()util regex to detect Samsung Browsers even if the "Desktop Mode" is enabled.Result
On Samsung Browsers, when the "Desktop Mode" is enabled,
enterKeyHintattribute is not updated, resulting in the input value not being reset.