Skip to content

fix(fetchAlgoliaResults): safely access searchClient credentials#1133

Merged
Haroenv merged 1 commit intonextfrom
fix/safer-check-credentials
Apr 26, 2023
Merged

fix(fetchAlgoliaResults): safely access searchClient credentials#1133
Haroenv merged 1 commit intonextfrom
fix/safer-check-credentials

Conversation

@Haroenv
Copy link
Copy Markdown
Contributor

@Haroenv Haroenv commented Apr 26, 2023

It's possible to have a broken / badly copied search client without transporter, and that would throw from 1.9.2 onwards.

This PR makes that access safer and throws a clear error.

CR-3338

It's possible to have a broken / badly copied search client without transporter, and that would throw from 1.9.2 onwards.

This PR makes that access safer and throws a clear error.

CR-3338
@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1ef62f9:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv Haroenv merged commit f0f7a62 into next Apr 26, 2023
@Haroenv Haroenv deleted the fix/safer-check-credentials branch April 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants