fix(algolia): throw error if searchClient is missing#1122
Merged
Conversation
It's a synchronous error, but as this is only for debugging, i don't think it makes a big difference how the error is thrown.
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 385c537:
|
dhayab
reviewed
Apr 13, 2023
packages/autocomplete-preset-algolia/src/search/fetchAlgoliaResults.ts
Outdated
Show resolved
Hide resolved
dhayab
approved these changes
Apr 17, 2023
packages/autocomplete-preset-algolia/src/search/fetchAlgoliaResults.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-preset-algolia/src/search/fetchAlgoliaResults.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-preset-algolia/src/search/__tests__/fetchAlgoliaResults.test.ts
Outdated
Show resolved
Hide resolved
dhayab
approved these changes
Apr 17, 2023
francoischalifour
approved these changes
Apr 17, 2023
packages/autocomplete-preset-algolia/src/requester/getAlgoliaFacets.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a synchronous error, but as this is only for debugging, i don't think it makes a big difference how the error is thrown.