fix(insights): add Algolia agent on subscribe#1058
Merged
sarahdayan merged 2 commits intonextfrom Dec 20, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sarahdayan
requested review from
a team,
FabienMotte,
Haroenv,
aymeric-giraudet and
dhayab
and removed request for
a team
Haroenv
approved these changes
Dec 20, 2022
Contributor
|
maybe instantsearch-autocomplete-plugin, but that's longer, and would be inconsistent with InstantSearch |
dhayab
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an Algolia agent on the Insights client when the plugin subscribes so that Insights calls coming from the plugin can be identified as such.
I'm making a direct call on the passed client and didn't implement an
addAlgoliaAgenton the wrapped client that we expose in methods. This saves a few bytes, and we don't want users to ever add agents anyway.Now that the Insights client sends at least one event on
subscribe, some tests had to be tightened as they were causing false positives.FX-2062