fix(chrome-only): Change autocomplete from 'nope' to 'off'#273
Merged
fix(chrome-only): Change autocomplete from 'nope' to 'off'#273
Conversation
Contributor
Author
|
We should probably make this an option, since it's so conflicting between versions. |
Contributor
|
@Haroenv totally agree. |
sdwvit
approved these changes
Dec 11, 2018
Contributor
Author
|
I'll add a way to customise this after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #250
see also #247 and fbbed04
cc @SchmidtDawid @Braunson @sdwvit
I could replicate this updated version behaving not as expected in Chrome, but also in Safari. Going back to a value as written in the specification (
off) seems like the way to go for this.