fix(utils): correct _.every method (#274)

* every now logical ANDs itself with results from previous iteration

* this is slightly more performant - if only calls the evaluator if it isn't encountered a false

* removing dist

* adding test to guarantee fixing of old functionality

* Update utils.js

Author: mlue

src/common/utils.js

@@ -64,9 +64,8 @@ module.exports = {
       return result;
     }
     this.each(obj, function(val, key) {
-      result = test.call(null, val, key, obj);
-      if (!result) {
-        return false;
+      if (result) {
+        result = test.call(null, val, key, obj) && result;
       }
     });
     return !!result;

test/unit/utils_spec.js

@@ -42,3 +42,22 @@ describe('escapeHTML', function() {
     expect(actual).toEqual(false);
   });
 });
+
+describe('every', function(){
+  it('_.every should return false when at least one result is true ', function(){
+    // simulating an implementation of Array.prototype.each
+    _.each = function(obj, callback) {
+      for (var i = 0; i < obj.length; i++){
+        callback(obj[i], i, _);
+        //note that we do not return here to break for loop, angular does not do this
+      }
+    };
+    expect(
+      _.every([
+        { isEmpty: function(){ return true; } },
+        { isEmpty: function(){ return false; } }
+      ], function (dataset) {
+        return dataset.isEmpty();
+    })).toEqual(false);
+  })
+});