fix(runtime): Do not lose exception in TS extends#1211
Merged
mbektchiev merged 4 commits intomasterfrom Oct 15, 2019
Merged
Conversation
* fix(JSC): Use `SuspendExceptionScope` instead of clearing exception * fix(runtime): Do not call initializer if `alloc` throws a JS exception * Add tests for erroneous TS extends * Add `tsconfig.json` and transpile `TypeScriptTests.ts`
darind
approved these changes
Oct 14, 2019
darind
approved these changes
Oct 14, 2019
vtrifonov
approved these changes
Oct 15, 2019
Memory for the temporary buffer created during marshalling to `functionWithUCharPtr` was accidentally being left intact on Intel and arm64 architectures, but on `armv7` it is overwritten, leading to CString test failing to check the actual result.
mbektchiev
force-pushed
the
bektchiev/dont-lose-exception
branch
from
4643a5c to
b0607f7
Compare
This test fails sporadically because GC may have not finished if the weak reference check is performed immediately after `__collect` returns. It most frequently failed on old `armv7` devices but not exclusively on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuspendExceptionScopeinstead of clearing exceptionallocthrows a JS exceptiontsconfig.jsonand transpileTypeScriptTests.tsPR Checklist
What is the current behavior?
Exceptions raised during TS extends call are lost and errors are difficult to detect.
What is the new behavior?
Exceptions raised during TS extends call are correctly thrown in JS and can be processed in a catch block or unhandled exception handler, or crash with a meaningful error.