Cleanups post widget merge (and on top of PR #419)#420
Closed
bharat wants to merge 23 commits intoLoopKit:devfrom
Closed
Cleanups post widget merge (and on top of PR #419)#420bharat wants to merge 23 commits intoLoopKit:devfrom
bharat wants to merge 23 commits intoLoopKit:devfrom
Conversation
Using two forks temporarily. Using bharat/SwiftCharts because we need the extension safe commits from master, but don't want the rest of the master branch yet. Using bharat/LoopKit because we want the warning fixes from LoopKit/LoopKit#111 which is not yet merged into LoopKit/dev
1. Change all explicit calls to .debugDescription over to String(describing:). This preserves existing behavior which was happening implicitly before swift 3.1 2. Use CGFloat.pi instead of CGFloat(Double.pi), and fix an issue where I accidentally negated one of the values in an earlier commit
Fix Swift 3.1 warnings from G4ShareSpy, ShareClient
…ianglesLayer to LoopUI . Changed the membership, but haven't moved the files yet . This requires creating a layer of abstraction on top of UIColor so that we can have a different set of colors for the widget vs. Loop . mark many internal vars/funcs in StatusChartsManager as public so that Loop's extension can access them.
bharat
changed the title
bharat
changed the title
added 8 commits
March 29, 2017 15:12
This reverts commit 0d486fd.
a gesture recognizer.
Author
|
Superceded by #424 |
ps2
pushed a commit
that referenced
this pull request
Jul 15, 2021
… permissions are disabled (#420) * LOOP-3647: Shows warning at top of home screen if CA or Notifications permissions are disabled * Cleaner impl of TempStatusCell * PR Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of small cleanups after the recent status widget merge. This is branched off of the code that's in #419 so until that gets merged you can see the deltas here:
https://github.com/bharat/Loop/compare/dev-frameworks-swift3.1...bharat:dev-3.1-cleanups?expand=1