fix(widget): capture document.currentScript before DOMContentLoaded (#676)#1054
Open
vianmora wants to merge 1 commit intoHiEventsDev:developfrom
Open
fix(widget): capture document.currentScript before DOMContentLoaded (#676)#1054vianmora wants to merge 1 commit intoHiEventsDev:developfrom
vianmora wants to merge 1 commit intoHiEventsDev:developfrom
Conversation
…ContentLoaded listener. By the time the listener fires, document.currentScript is null, causing a crash. Capturing the reference at IIFE invocation time fixes the issue regardless of script placement or loading strategy.
vianmora
force-pushed
the
fix/widget-currentscript-null
branch
from
d04d693 to
ce9488b
Compare
Author
|
I see that this PR fix actually the same issue : #677 |
vianmora
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When widget.js is loaded in without async, the browser executes the script while the DOM is still parsing (readyState === 'loading'). The IIFE registers a DOMContentLoaded listener and returns. By the time that listener fires, document.currentScript is null, causing a silent crash:
Uncaught TypeError: Cannot read properties of null (reading 'src')=> The widget never renders.
Fix
Capture document.currentScript at IIFE invocation time and pass it as a parameter. The reference remains valid regardless of when loadWidget() is eventually called. No need to put the script in head, you can now put it wherever you want in the body.
I think it can also resolve #676
Checklist